Review Request 119552: Kdeclarative: Introduce org.kde.kio component

Aleix Pol Gonzalez aleixpol at kde.org
Thu Jul 31 11:10:10 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119552/#review63550
-----------------------------------------------------------



src/qmlcontrols/kioplugin/CMakeLists.txt
<https://git.reviewboard.kde.org/r/119552/#comment44288>

    Call it kio_qml_plugin?



src/qmlcontrols/kioplugin/kio.cpp
<https://git.reviewboard.kde.org/r/119552/#comment44289>

    Why is it better than Qt.openUrl?
    
    And what does this have to do with KIO?


- Aleix Pol Gonzalez


On July 31, 2014, 10:54 a.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119552/
> -----------------------------------------------------------
> 
> (Updated July 31, 2014, 10:54 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> With the specific component we will be able to open files,documents,applications etc.
> Because until now we are not able to open them.
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/CMakeLists.txt bab913b 
>   src/qmlcontrols/kioplugin/CMakeLists.txt PRE-CREATION 
>   src/qmlcontrols/kioplugin/kio.h PRE-CREATION 
>   src/qmlcontrols/kioplugin/kio.cpp PRE-CREATION 
>   src/qmlcontrols/kioplugin/kioplugin.h PRE-CREATION 
>   src/qmlcontrols/kioplugin/kioplugin.cpp PRE-CREATION 
>   src/qmlcontrols/kioplugin/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119552/diff/
> 
> 
> Testing
> -------
> 
> Everything seems to work ok.
> 
> * Applications open properly if we pass their desktop file as a parameter
> * Files and images are opening properly
> 
>  
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140731/ae7bf18c/attachment.html>


More information about the Plasma-devel mailing list