Review Request 116898: Get rid of unnecessary Q_INVOKABLE declarations

Shantanu Tushar shantanu at kde.org
Tue Jul 29 13:19:55 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116898/
-----------------------------------------------------------

(Updated July 29, 2014, 1:19 p.m.)


Status
------

This change has been discarded.


Review request for Plasma and Sujith Haridasan.


Repository: plasma-mediacenter


Description
-------

Methods supposed to be used as READ of Q_PROPERTY properties need not be invokable. Same goes for slots.


Diffs
-----

  libs/mpris2/mediaplayer2.h e68bc5c 
  libs/mpris2/mediaplayer2player.h 203d681 
  libs/mpris2/mpris2.h 0df64f4 
  libs/mpris2/mpris2.cpp a8ad3ef 
  shells/newshell/main.cpp bab6915 
  shells/newshell/mainwindow.cpp d2d71d4 

Diff: https://git.reviewboard.kde.org/r/116898/diff/


Testing
-------


Thanks,

Shantanu Tushar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140729/b93e767f/attachment.html>


More information about the Plasma-devel mailing list