Review Request 111087: widget-taskbar: vertical text layout

[Greg T]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/111087/
-----------------------------------------------------------

(Updated July 29, 2014, 12:16 p.m.)


Status
------

This change has been discarded.


Review request for Plasma.


Bugs: 314879
    http://bugs.kde.org/show_bug.cgi?id=314879


Repository: kde-workspace


Description
-------

welcome to the taskbar bug marathon ;)

this change corrects the issue reported in the report. the diff is trivial (though I think the tasklabel code is silly and too complex) but I'm not sure if I can approve the aesthetic consequences (see screenshot): the text moves slightly to the top of the label area, but imho relative to the vertically centered icon widget it looks misplaced.

What do you think?


Diffs
-----

  plasma/desktop/applets/tasks/support/textlabel.cpp 9fbc12d621c2917665fb963c0087f3a59c9e86e9 

Diff: https://git.reviewboard.kde.org/r/111087/diff/


Testing
-------


File Attachments
----------------


  https://git.reviewboard.kde.org/media/uploaded/files/2013/06/18/taskbar_nocut.png


Thanks,

Greg T

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140729/79fde5da/attachment-0001.html>