Review Request 106978: Fix Inconsistencies and Bugs in Activity Bar's Size Hinting

[David Narváez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/106978/
-----------------------------------------------------------

(Updated July 29, 2014, 9:27 a.m.)


Status
------

This change has been discarded.


Review request for Plasma.


Bugs: 225078
    http://bugs.kde.org/show_bug.cgi?id=225078


Repository: kde-workspace


Description
-------

The main issue was caused by the fact that asking the tab bar native widget to provide a size hint was giving a different size every time which caused the activity bar to expand or shrink in the presence of another expanding widget (in my case, the taskbar), so this patch decides a size hint from the size of the containment (one third of the width of height depending on the form factor) but the size policy is set to expand when the activity bar is the only widget in the containment.


Diffs
-----

  plasma/generic/applets/activitybar/activitybar.cpp e66bf04 

Diff: https://git.reviewboard.kde.org/r/106978/diff/


Testing
-------

1) Add a panel with an actyivity bar and a task bar
2) Add a panel with an activty bar only
3) Change activities

Before this patch, the activity bar in the panel with a task bar shrinks or enlarges with every activity change; while the size of the activity bar in the second panel remains constant. After this patch, the size of the activity bar in both panels remains constant.


Thanks,

David Narváez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140729/fb231f08/attachment.html>