Review Request 116722: Allow setTransientParent from an item
David Edmundson
david at davidedmundson.co.uk
Tue Jul 29 08:53:29 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116722/
-----------------------------------------------------------
(Updated July 29, 2014, 8:53 a.m.)
Status
------
This change has been discarded.
Review request for Plasma.
Repository: plasma-framework
Description
-------
Allow setTransientParent from an item
Because QWindow is not exposed as a property of Item in certain cases we
may not have access to the owning window in a qml that has menus. For
example WidgetExplorer.
This patch also fixes crash in setTransientParent is called before a window is set on
the menu.
Diffs
-----
src/declarativeimports/plasmacomponents/qmenu.h d1a5b73
src/declarativeimports/plasmacomponents/qmenu.cpp a9b41a9
Diff: https://git.reviewboard.kde.org/r/116722/diff/
Testing
-------
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140729/6eb7f76f/attachment-0001.html>
More information about the Plasma-devel
mailing list