Review Request 119523: port TextField to QtControls

[David Edmundson]

On July 28, 2014, 6:54 p.m., Marco Martin wrote:
> > Which methods do we need the inner control for? I saw positionAtPos and positionToRectangle, any others?
> 
> Marco Martin wrote:
>     those two and passwordCharacter

and missing properties are:

passwordCharacter
errorHighlight


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119523/#review63363
-----------------------------------------------------------


On July 28, 2014, 6:10 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119523/
> -----------------------------------------------------------
> 
> (Updated July 28, 2014, 6:10 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> this ports TextField to Qt Controls.
> 
> Not sure if is really meargeable tough, because the old one used to export several properties and functions more, but they are not possible anymore, because in order for them to work is needed the access to the internal TextInput, and we don't have that, so some api should have to be dropped, breaking the compatibility promise.
> (another option would be to still use an own implementation, but use a compatible style anyways)
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/TextField.qml 5bc6b58 
>   src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140728/5626dcdf/attachment.html>