Review Request 119524: Force OpenGLES if on Qt 5.4

Aleix Pol Gonzalez aleixpol at kde.org
Mon Jul 28 18:09:58 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119524/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-workspace


Description
-------

When trying to reduce memory usage in plasma shell, we realized that one of the reasons we got such big memory footprint was actually the intel driver (on intel systems, that is). After some investigation, David found out we were going through some memory-consuming path [1]. A way to workaround it is by using only OpenGLES. Everything still works here after this patch, so it seems to be a good change to get in.

This change needs Qt 5.4, to get the new API that lets us enforce a QSurfaceFormat, hence having it ifdef'd.
I'm quite unaware of problems we might find. Knowing we probably want to work in different embedded devices, suggests that OpenGLES on all platforms sounds like a safe bet.

[1] http://comments.gmane.org/gmane.comp.video.mesa3d.devel/60848


Diffs
-----

  shell/main.cpp e34578d 

Diff: https://git.reviewboard.kde.org/r/119524/diff/


Testing
-------

I'm using it now, without visible problems. Now we see no trace of i915 in the massif reports.


File Attachments
----------------

before
  https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/5a6beb4f-24c0-4cee-a7a2-038385e35119__plasma-massif-opengl.png
after
  https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/fc301ff5-cb1d-4654-a57f-82990220c8e3__plasma-massif-opengles.png


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140728/6f3c832c/attachment.html>


More information about the Plasma-devel mailing list