Review Request 119522: readlink fails whens the folder does not exist.

[Rohan Garg]

> On July 28, 2014, 11:14 p.m., Aleix Pol Gonzalez wrote:
> > So does it still work if it's a link, after this patch?

Yep, works when my ~/.config is a symlink.


- Rohan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119522/#review63351
-----------------------------------------------------------


On July 28, 2014, 10:47 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119522/
> -----------------------------------------------------------
> 
> (Updated July 28, 2014, 10:47 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/f01badb5aa3f76b27955f4fee2cb7281dd490353 introduced a regression in startkde whereby if ~/.config does not exist readlink will not output the right path.
> 
> This leads to startkde trying to write to /startupconfigkeys or /kdeglobals which obviously won't work.
> 
> Since the original commit mentions that relative paths weren't working, I've taken a alternative approach of using ${HOME} instead.
> 
> 
> Diffs
> -----
> 
>   startkde/startkde.cmake 281bd43 
> 
> Diff: https://git.reviewboard.kde.org/r/119522/diff/
> 
> 
> Testing
> -------
> 
> Kubuntu Plasma 5 ISO's did not have the right cursor theme before this patch, after editing startkde by hand, the right files were being correctly written, and the cursor theme worked as expected.
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140728/05246faa/attachment-0001.html>