Review Request 119465: Have separate texture hashes for each window

[David Edmundson]

> On July 25, 2014, 4:36 p.m., Marco Martin wrote:
> > src/declarativeimports/core/framesvgitem.cpp, line 49
> > <https://git.reviewboard.kde.org/r/119465/diff/1/?file=292708#file292708line49>
> >
> >     when a qquickwindow gets deleted.. does it delete all the QSGTextures created with createTextureFromImage?

No. Ownership is always transferred to the recipient. (and this is using QSharedPointer to then manage them)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119465/#review63172
-----------------------------------------------------------


On July 25, 2014, 2:28 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119465/
> -----------------------------------------------------------
> 
> (Updated July 25, 2014, 2:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Apparently in nvidia we get corruptions when a texture created for a window is used in another one.
> With this patch we tell the texture has changed when we move it from a window to another, so it's re-created and we keep textures for all windows separately. This way we ensure they don't mix.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/framesvgitem.h 0b39c70 
>   src/declarativeimports/core/framesvgitem.cpp ebac29f 
> 
> Diff: https://git.reviewboard.kde.org/r/119465/diff/
> 
> 
> Testing
> -------
> 
> Still works here, I hope Marco can confirm it fixes the problem.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140725/22e4eabf/attachment.html>