Review Request 119425: Cache the textures created for the fast path

[Marco Martin]

> On July 25, 2014, 1:55 p.m., Marco Martin wrote:
> > To me, at least on Nvidia seems that graphics gets completely broken for popup contents.
> > 
> > I think it should watch for widow change and delete the cache/rebuild the textures in that case
> 
> Aleix Pol Gonzalez wrote:
>     Do you have a picture?
>     
>     Here (intel) it looks fine. At least I tried moving the panel from a screen to the other and it seemed to stay put, with all the tooltips and such.
> 
> Marco Martin wrote:
>     http://wstaw.org/m/2014/07/25/plasma-desktopvE1748.png
>     
>     can try to bisect to see if it really came up from that patch or before
> 
> Marco Martin wrote:
>     in the example above, i loaded it in plasmoidviewer, then resized to switc some times between full and popup

yep, reliably doesn't happen anymore on f6e4cb790ec815cad0cb7be40f7145f08b034693 that's the one before this has been berged


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119425/#review63152
-----------------------------------------------------------


On July 25, 2014, 10:57 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119425/
> -----------------------------------------------------------
> 
> (Updated July 25, 2014, 10:57 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Create a cache that has pointers to all the textures that we've generated, so in case we have one already created, we can re-use it.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/framesvgitem.cpp 323b06b 
>   src/declarativeimports/core/iconitem.cpp 38012cc 
>   src/declarativeimports/core/svgitem.cpp eccff55 
>   src/declarativeimports/core/svgtexturenode.h 21b9b2f 
>   src/desktoptheme/air/widgets/lineedit.svgz 8b3a123 
> 
> Diff: https://git.reviewboard.kde.org/r/119425/diff/
> 
> 
> Testing
> -------
> 
> see the qDebug (to be removed before commit). 
> 
> plasmashell 2> out
> $ grep s_cache out | grep ": miss" | wc -l
> 342
> $ grep s_cache out | grep ": hit" | wc -l
> 126
> 
> So still having 3 times more hits than miss, so there's big room for improvement. Good news is that with this, we get a ~25% of memory and bandwidth save, in a per-item basis.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140725/0320368d/attachment.html>