Review Request 119455: make Button a QtControl

[Marco Martin]

> On July 24, 2014, 4:56 p.m., David Edmundson wrote:
> > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 41
> > <https://git.reviewboard.kde.org/r/119455/diff/2/?file=292510#file292510line41>
> >
> >     This isn't very declarative, is there a reason we can't do:
> >     
> >     
> >     Button
> >     {
> >       style: ButtonStyle{}
> >       property alias minimumWidth: style.minimumWidth 
> >     }
> >     
> >     and in this file
> >     
> >     property alias minimumWidth: buttonContent.minimumWidth
> >     
> >     same for height

as far i know, the only way to access the style is with like minimumWidth: __style.minimumWidth

was to avoid the private property since the __
if we are sure __style is not going to be removed, sine, but i would be not so sure of that


> On July 24, 2014, 4:56 p.m., David Edmundson wrote:
> > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 58
> > <https://git.reviewboard.kde.org/r/119455/diff/2/?file=292510#file292510line58>
> >
> >     if you want fd-o icons, generally you use iconName instead of iconSource.
> >     
> >     We may need some changes for source compatibility, but that should be in the Button rather than the style I think.

I'll have to override iconsource to be an alias of iconname then, since all the users use only iconSource


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119455/#review63091
-----------------------------------------------------------


On July 24, 2014, 4:31 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119455/
> -----------------------------------------------------------
> 
> (Updated July 24, 2014, 4:31 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> this makes Button inherit from the QtControl and annd an accompaining plasma-looking theme
> 
> now, the ugly part of the patch:
> iconSource is an url, so it screws up passing freedesktop compatible names (it expects names of pngs local to the qml file directory, testimony of the main platform target for controls actually being android/ios). one solution may be overriding iconSource as a normal string, but i would like the theme working also on a plain Button, so it extract only the filename from the url.
> 
> 
> Diffs
> -----
> 
>   examples/applets/widgetgallery/contents/ui/Buttons.qml 9134df9 
>   src/declarativeimports/core/iconitem.cpp 38012cc 
>   src/declarativeimports/plasmacomponents/qml/Button.qml 262e20f 
>   src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119455/diff/
> 
> 
> Testing
> -------
> 
> in both a normal plasma session or the widget gallery buttons work fine, painting is 100% identical
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140724/a55a346d/attachment.html>