Review Request 119430: Don't remove dbus-activated plasmoids too early.

[Anton Kreuzkamp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119430/
-----------------------------------------------------------

(Updated July 23, 2014, 7:40 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Sebastian Kügler.


Repository: plasma-workspace


Description
-------

The systemtray plugin for dbus-activated plasmoids removed the
plasmoid as soon as a service vanished, that matched the pattern.
This behavior broke as soon as there're multiple matchin services,
e.g. the mediacontroller plasmoid when multiple mpris2-mediaplayers
are started. As soon as you quit one application, the plasmoid would
get removed.

With this patch the plasmoid only gets removed after the last service
quit.


Diffs
-----

  applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.h e77bae1f58377068be7c306d56073b626240abcd 
  applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.cpp 992c7f3226cc0f71c085e9148179b2e44dcd2e4f 

Diff: https://git.reviewboard.kde.org/r/119430/diff/


Testing
-------

Only tested with mediacontroller plasmoid. Works there.


Thanks,

Anton Kreuzkamp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140723/f456a391/attachment-0001.html>