Review Request 119424: Fix paths used in kstartupconfig

[Luca Beltrame]

> On Lug. 23, 2014, 2:06 p.m., Luca Beltrame wrote:
> > Question: instead of writing into ~/.config, why not using ~/.config/plasma-workspace? (for all the programs mentioned). IMO it does not make sense to pollute the root of ~/.config. plasma-workspace is already used by startkde and the autostart KCM.
> 
> David Edmundson wrote:
>     Note, that 2 other scripts startkde and kdostartupconfig5 expect the path here. This brings that in line with the others.
>     
>     I do mostly agree with you though but thought if I said it I'd break my chances of getting this as a small patch into 5.0.x ;)
>     
>     Moving won't be trivial, kstartupconfig parses kdeglobals which it expects in the same dir, and that would mean changing frameworks integration too.. and a tonne more code

OK, then it's not as trivial as I thought. But at least I think it's something for the future.


- Luca


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119424/#review62962
-----------------------------------------------------------


On Lug. 23, 2014, 1:56 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119424/
> -----------------------------------------------------------
> 
> (Updated Lug. 23, 2014, 1:56 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Fix paths used in kstartupconfig
> 
> kstartupconfig was looking in .config/share/startupconfigkeys
> 
> startkde and kdostartupconfig write to .config/startupconfigkeys
> 
> End result settings such as those in ksplash were ignored
> 
> I want to put this in the stable branch so it's in 5.0.1
> 
> 
> Diffs
> -----
> 
>   startkde/kstartupconfig/kstartupconfig.cpp f0b902a 
> 
> Diff: https://git.reviewboard.kde.org/r/119424/diff/
> 
> 
> Testing
> -------
> 
> modified ksplashrc.
> checked kstartupconfig actually had this change instead of resetting to default.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140723/f1e8dfd4/attachment.html>