Review Request 119409: framework part of the applet alternatives shooser

Marco Martin notmart at gmail.com
Wed Jul 23 10:31:13 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119409/
-----------------------------------------------------------

(Updated July 23, 2014, 10:31 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
-------

this is the little part in plasma-framework for the applet alternatives chooser.
works together the branch mart/alternativesConfig of plasma-workspace and plsma-desktop.
for how it looks and why, see the vdg forum thread:
https://forum.kde.org/viewtopic.php?f=285&t=122067&p=315919#p315919

still possible problems:
* the branch in framework is kinda screwed, too many merges, is probably better to push this diff as a single commit
* I'm not sure about using a new desktop file entry X-Plasma-Provides, *maybe* Categories could be enough, but it may produce many false positives as well


Diffs
-----

  src/plasma/applet.cpp 0afb4a7 
  src/plasma/containment.h 968b3e2 
  src/plasma/data/servicetypes/plasma-applet.desktop b75c3d6 
  src/plasma/private/applet_p.cpp 92b12ac 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp 457f898 

Diff: https://git.reviewboard.kde.org/r/119409/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140723/603604b4/attachment.html>


More information about the Plasma-devel mailing list