Review Request 119411: Plasmate-Kdev: Port plasmate to KDevPlatform's shell part 1

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119411/#review62906
-----------------------------------------------------------


> I have separated this task to two reviews, because there are also some
git mv in order to have a decent directory structure which I don't have

FYI: If you create the diff with --find-renames it /should/ track the file movements.

You've split things now, so it's possibly not worth updating, but might make your life a bit easier next time.

- David Edmundson


On July 22, 2014, 5:47 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119411/
> -----------------------------------------------------------
> 
> (Updated July 22, 2014, 5:47 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasmate
> 
> 
> Description
> -------
> 
> I have separated this task to two reviews, because there are also some
> `git mv` in order to have a decent directory structure which I don't have
> included in this review for readability.
> 
> Below is the list of commits from which this review has been made.
> 
> ----
> 
> * use some private members and improve readability
> 
> ----
> * Every project must have a .plasmate file in order to pick the Manager.
> 
> ----
> * Initial commit for porting plasmate to kdevplatform
> 
> We introduce a new class named PlasmateApp which will
> show the Startpage and hide it, when it must do it.
> 
> 
> Diffs
> -----
> 
>   plasmate/CMakeLists.txt 1a6ce8799741b70abf4d19c7df9ea1d11d4779f8 
>   plasmate/app/main.cpp PRE-CREATION 
>   plasmate/app/plasmateapp.h PRE-CREATION 
>   plasmate/app/plasmateapp.cpp PRE-CREATION 
>   plasmate/app/plasmateextention.h PRE-CREATION 
>   plasmate/app/plasmateextention.cpp PRE-CREATION 
>   plasmate/app/plasmateui.rc PRE-CREATION 
>   plasmate/main.cpp 633c4cc86b4795418d1ed90028165615a2e6f2ec 
>   plasmate/plasmateui.rc 41f602591cf9596c0dae13f111845630e96f19f6 
>   plasmate/startpage.h 4c77e29bc2dd93977e06bdeec45c753a568e374a 
>   plasmate/startpage.cpp a65a2cc48afa4eef0db6d6248e31ac2111b42d8d 
> 
> Diff: https://git.reviewboard.kde.org/r/119411/diff/
> 
> 
> Testing
> -------
> 
> You can also test this review from
> 
> url: http://quickgit.kde.org/?p=clones%2Fplasmate%2Ftsiapaliwkas%2Fplasmate-kdevplatform.git
> git: git://anongit.kde.org/clones/plasmate/tsiapaliwkas/plasmate-kdevplatform.git
> branch: r/119411
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140722/346df071/attachment.html>