Review Request 118180: slideshow BUG patch fix

Sebastian Kügler sebas at kde.org
Mon Jul 21 13:02:41 UTC 2014



> On July 21, 2014, 12:39 p.m., Martin Gräßlin wrote:
> >
> 
> TOM Harrison wrote:
>     what kind of issue? tab and space different ?

Yes, don't use tabs at all for code indentation, use 4 spaces. It should look consistent with the surrounding code after that.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118180/#review62779
-----------------------------------------------------------


On June 5, 2014, 10:32 a.m., TOM Harrison wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118180/
> -----------------------------------------------------------
> 
> (Updated June 5, 2014, 10:32 a.m.)
> 
> 
> Review request for kde-workspace and Plasma.
> 
> 
> Bugs: 327580
>     http://bugs.kde.org/show_bug.cgi?id=327580
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> bug patch for slideshow dir list missing
> 
> 
> Diffs
> -----
> 
>   libs/plasmagenericshell/backgrounddialog.cpp 645de3f 
> 
> Diff: https://git.reviewboard.kde.org/r/118180/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> TOM Harrison
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140721/fcc948fa/attachment.html>


More information about the Plasma-devel mailing list