Review Request 119379: Lockscreen accessibility

[Frederik Gladhorn]

> On July 20, 2014, 4:11 p.m., David Edmundson wrote:
> > lookandfeel/contents/components/LogoutOptions.qml, line 64
> > <https://git.reviewboard.kde.org/r/119379/diff/1/?file=291353#file291353line64>
> >
> >     I think this may need to be i18ncd; unless someone is setting the catalog on the c++ side. 
> >     Current code has a mix, so Im not sure.

That was actually the main reason for the review request - I dunno how the catalog stuff works these days. It would be great if someone could shed some light on this :)


> On July 20, 2014, 4:11 p.m., David Edmundson wrote:
> > lookandfeel/contents/components/LogoutOptions.qml, line 94
> > <https://git.reviewboard.kde.org/r/119379/diff/1/?file=291353#file291353line94>
> >
> >     Should we put this into PlamsaComponents.ToolButton itself?
> >     
> >     Is there ever a case where we wouldn't want a toolbutton to be in the tab chain?

I just sent a mail to plasma-devel, I completely agree on this one.


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119379/#review62741
-----------------------------------------------------------


On July 20, 2014, 4:05 p.m., Frederik Gladhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119379/
> -----------------------------------------------------------
> 
> (Updated July 20, 2014, 4:05 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Make lockscreen buttons say something and let shutdown/lock/reboot buttons get focus.
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/components/LogoutOptions.qml d3ccea0 
>   lookandfeel/contents/components/UserDelegate.qml 2221368 
> 
> Diff: https://git.reviewboard.kde.org/r/119379/diff/
> 
> 
> Testing
> -------
> 
> Tested with Orca.
> 
> 
> Thanks,
> 
> Frederik Gladhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140720/80e9bc9c/attachment-0001.html>