Review Request 119250: Events and trips according to date ranges

[Sinny Kumari]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119250/#review62740
-----------------------------------------------------------


Works fine now. Just two minor fix:
1. New events with blank name shouldn't be created. Save button should be disabled until name some valid name is enterd
2. Creating a new event with an existing event name ends up editing same. Ideally, it should give error message saying event already exits.

- Sinny Kumari


On July 20, 2014, 3:08 p.m., Shantanu Tushar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119250/
> -----------------------------------------------------------
> 
> (Updated July 20, 2014, 3:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> I got this idea on a recent trip that usually a family would have a device where they store their trips/events photos on. Easier than tagging everything, what if you could just say "Hey, I went to Kashmir during 5 April to 14 April 2014" and voila!
> 
> This backend implements this idea in a (hopefully) easy-to-use way. I'll love to hear some feedback around this :)
> 
> 
> Diffs
> -----
> 
>   browsingbackends/metadatabackends/eventsbackend/eventsfiltermodel.cpp PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsmodel.h PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsmodel.cpp PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventspicturesmodel.h PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventspicturesmodel.cpp PRE-CREATION 
>   browsingbackends/onlineservices/picasa/picasabackend.h 83b3eb2 
>   browsingbackends/onlineservices/picasa/picasabackend.cpp b01ba4a 
>   browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml d15a46e 
>   libs/mediacenter/abstractbrowsingbackend.h 14ad502 
>   libs/mediacenter/abstractbrowsingbackend.cpp 6cd32f8 
>   libs/mediacenter/backendsmodel.cpp 2823fb6 
>   libs/mediacenter/filtermediamodel.h b8272f6 
>   mediaelements/mediabrowser/MediaBrowser.qml b4ebdf9 
>   shells/newshell/package/contents/ui/mediacenter.qml 15c9cee 
>   browsingbackends/metadatabackends/CMakeLists.txt ae56603 
>   browsingbackends/metadatabackends/eventsbackend/CMakeLists.txt PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsbackend.cpp PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsbackend.desktop PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsbackend.h PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventscomponents/DatePicker.qml PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventscomponents/Digit.qml PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventscomponents/EventsConfiguration.qml PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventscomponents/qmldir PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsfiltermodel.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119250/diff/
> 
> 
> Testing
> -------
> 
> Seems to work as expected, I will be attaching screenshots.
> 
> 
> File Attachments
> ----------------
> 
> Showing events
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/c4c99bbd-f77f-4167-922e-79f90949040b__events.png
> Showing photos from an event
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/a4ed7663-64b6-4963-aed3-5e41cc8e51ee__showing-event.png
> Editing dates of an existing event
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/965b667b-e209-44a3-bc64-95f81b18913e__editing-event.png
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140720/5ebaa6b6/attachment.html>