Review Request 119025: Actually pass IBUS_DEFINITIONS when compiling ibus-panel

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119025/#review62669
-----------------------------------------------------------



cmake/FindIBus.cmake
<https://git.reviewboard.kde.org/r/119025/#comment43439>

    Typo: paramaters


(As a general note, for build system related stuff like this you can also try including the "buildsystem" group, which can be more responsive at times)

> The ibus-panel can't build on OpenBSD because some required definitions obtained from pkgconfig file are not used.
> 1. IBUS_DEFINITIONS is not used in ibus-panel/CMakeLists.txt

Can you post the error you get here? I've tried building kimtoy here on FreeBSD expecting to hit the same issue(s), but it all went along just fine.

> 2. IBUS_DEFINITIONS is not saved in cache, and thus isn't available at compile time

This doesn't make much sense; all values found at configuration time in CMake are then used to generate your make/ninja/whatever files, regardless of whether they are cached or not.

- Raphael Kubo da Costa


On July 12, 2014, 4:12 p.m., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119025/
> -----------------------------------------------------------
> 
> (Updated July 12, 2014, 4:12 p.m.)
> 
> 
> Review request for kde-workspace, Plasma and Hui Ni.
> 
> 
> Repository: kimtoy
> 
> 
> Description
> -------
> 
> The ibus-panel can't build on OpenBSD because some required definitions obtained from pkgconfig file are not used. This happens due to the following reasons:
> 
> 1. IBUS_DEFINITIONS is not used in ibus-panel/CMakeLists.txt
> 2. IBUS_DEFINITIONS is not saved in cache, and thus isn't available at compile time
> 
> This patch resolves both issues and makes ibus-panel compile on OpenBSD.
> 
> (I found no suitable review group and therefore used "plasma" instead, as it was in "plasma-addons" previously; please, feel free to correct me if I'm wrong and sorry for any possible inconvenience)
> 
> ((as there was no feedback for more than a week, I've added "kde-workspace" group to list of reviewers, too))
> 
> 
> Diffs
> -----
> 
>   cmake/FindIBus.cmake 8250c49 
>   ibus-panel/CMakeLists.txt 3a1ee49 
> 
> Diff: https://git.reviewboard.kde.org/r/119025/diff/
> 
> 
> Testing
> -------
> 
> OpenBSD/i386-CURRENT, KDE 4.13 (it doesn't have kimtoy package, of course, but the code is same)
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140718/c91a0473/attachment.html>