Review Request 119357: Replace SpringAnimation with NumberAnimation with EaseOutIn

David Edmundson david at davidedmundson.co.uk
Fri Jul 18 16:21:42 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119357/
-----------------------------------------------------------

(Updated July 18, 2014, 4:21 p.m.)


Review request for Plasma and Bhushan Shah.


Changes
-------

Tweaked animation to to Aleix's preference to be more springy.


Repository: plasma-workspace


Description
-------

Replace SpringAnimation with NumberAnimation with EaseOutIn

SpringAnimation ignores duration property and will keep animating until
the item has stopped springing; this takes a long time >= 1s just with the movements getting unoticably smaller.

This means the analog clock is constantly repainting the entire desktop
causing high load.

This now restricts it to 200ms, so it's 5x less load.

Animation looks practically the same; but someone might want to play with the various easing properties.


BUG: 335442


Diffs (updated)
-----

  applets/analog-clock/contents/ui/Hand.qml 48fcb69 

Diff: https://git.reviewboard.kde.org/r/119357/diff/


Testing
-------


File Attachments
----------------

clock_before.png
  https://git.reviewboard.kde.org/media/uploaded/files/2014/07/18/c03efc1c-0b8d-4306-b784-ce1f719a490b__clock_before.png
clock_after.png
  https://git.reviewboard.kde.org/media/uploaded/files/2014/07/18/58f15fd9-11df-40cb-9ef9-a47dbd48b228__clock_after.png


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140718/fc3ad3f5/attachment.html>


More information about the Plasma-devel mailing list