Review Request 119344: add close button to fullscreen mode, bug #319099

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119344/#review62600
-----------------------------------------------------------



fullscreen/package/contents/ui/main.qml
<https://git.reviewboard.kde.org/r/119344/#comment43407>

    Can you just do "width: visible ? implicitWidth : 0;" in the close button itself? Nicer to keep things local.


- Eike Hein


On July 17, 2014, 4:19 p.m., Drake Justice wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119344/
> -----------------------------------------------------------
> 
> (Updated July 17, 2014, 4:19 p.m.)
> 
> 
> Review request for Homerun and Plasma.
> 
> 
> Repository: homerun
> 
> 
> Description
> -------
> 
> adds a close button to the topright of fullscreen, only visible if not a containment. 
> 
> 
> Diffs
> -----
> 
>   fullscreen/package/contents/ui/main.qml d7d52a1 
> 
> Diff: https://git.reviewboard.kde.org/r/119344/diff/
> 
> 
> Testing
> -------
> 
> desktop containment and panel containment. 
> 
> 
> Thanks,
> 
> Drake Justice
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140717/5b7b32cc/attachment-0001.html>