Review Request 119322: Make it possible to run the widgetsgallery from qmlscene

David Edmundson david at davidedmundson.co.uk
Wed Jul 16 15:39:05 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119322/#review62517
-----------------------------------------------------------

Ship it!


Makes sense. I've found it annoying that I can't run it in qmlscene when testing things sometimes.


examples/applets/widgetgallery/contents/ui/standalonemain.qml
<https://git.reviewboard.kde.org/r/119322/#comment43374>

    This is a root item, so setting Layout.anything won't do anything. standard width/height makes more sense here.



examples/applets/widgetgallery/contents/ui/standalonemain.qml
<https://git.reviewboard.kde.org/r/119322/#comment43375>

    delete this.


- David Edmundson


On July 16, 2014, 3:36 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119322/
> -----------------------------------------------------------
> 
> (Updated July 16, 2014, 3:36 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Adds a new entry point to the widgets gallery so we can test it from qmlscene.
> 
> It's a valid use case for the components and the best tool we have for testing that we didn't break components.
> 
> 
> Diffs
> -----
> 
>   examples/applets/widgetgallery/contents/ui/standalonemain.qml PRE-CREATION 
>   examples/applets/widgetgallery/contents/ui/Buttons.qml 379585f 
>   examples/applets/widgetgallery/contents/ui/Menu.qml 1336c42 
> 
> Diff: https://git.reviewboard.kde.org/r/119322/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140716/eaaabb37/attachment.html>


More information about the Plasma-devel mailing list