Review Request 119283: Replace Calendar grid with Canvas
Martin Klapetek
martin.klapetek at gmail.com
Tue Jul 15 07:33:06 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119283/
-----------------------------------------------------------
(Updated July 15, 2014, 9:33 a.m.)
Review request for Plasma.
Changes
-------
Fixed outer rect calculation
Repository: plasma-framework
Description
-------
This patch simplifies the grid a bit more by using Canvas instead of Rectangles, so actually lowering the number of Items needed to create the grid from 16 to just 1.
It works pretty neatly with no junctions problem at all.
Diffs (updated)
-----
src/declarativeimports/calendar/qml/DayDelegate.qml d626441
src/declarativeimports/calendar/qml/DaysCalendar.qml 1249de2
src/declarativeimports/calendar/qml/MonthView.qml 4946635
Diff: https://git.reviewboard.kde.org/r/119283/diff/
Testing
-------
File Attachments
----------------
Screenshot before/after
https://git.reviewboard.kde.org/media/uploaded/files/2014/07/14/e744e403-89ff-4947-95eb-3ade4823ebb5__plasma_cal_canvas.png
Thanks,
Martin Klapetek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140715/ec9bbcfe/attachment.html>
More information about the Plasma-devel
mailing list