Review Request 119279: Use 'KXMLGUI_INSTALL_DIR' instead of 'DATA_INSTALL_DIR'
David Edmundson
david at davidedmundson.co.uk
Mon Jul 14 21:18:18 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119279/#review62338
-----------------------------------------------------------
Ship it!
CMakeLists.txt
<https://git.reviewboard.kde.org/r/119279/#comment43304>
If you're feeling bored can you tidy up the spacing here before pushing.
- David Edmundson
On July 14, 2014, 7:41 p.m., Elias Probst wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119279/
> -----------------------------------------------------------
>
> (Updated July 14, 2014, 7:41 p.m.)
>
>
> Review request for Documentation and Plasma.
>
>
> Repository: khelpcenter
>
>
> Description
> -------
>
> The kxmlgui file for khelpcenter is installed into a deprecated location.
> This patch fixes this and the deprecation notice on khelpcenter startup isn't shown anymore (*KXMLGUI file found at deprecated location ("/usr/share/khelpcenter/khelpcenterui.rc") -- please use ${KXMLGUI_INSTALL_DIR} to install this file instead.*)
>
>
> Diffs
> -----
>
> CMakeLists.txt dea527d757c01ae92bb34c60d6f59f5af2cd8a7d
>
> Diff: https://git.reviewboard.kde.org/r/119279/diff/
>
>
> Testing
> -------
>
> khelpcenter works.
> No deprecation notice shown anymore.
>
>
> Thanks,
>
> Elias Probst
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140714/7f8fdbb2/attachment.html>
More information about the Plasma-devel
mailing list