Review Request 119281: Use 'KXMLGUI_INSTALL_DIR' instead of 'DATA_INSTALL_DIR'

David Edmundson david at davidedmundson.co.uk
Mon Jul 14 21:16:40 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119281/#review62336
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On July 14, 2014, 8:48 p.m., Elias Probst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119281/
> -----------------------------------------------------------
> 
> (Updated July 14, 2014, 8:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: systemsettings
> 
> 
> Description
> -------
> 
> The kxmlgui file for systemsettings is installed into a deprecated location.
> This patch fixes this and the deprecation notice on systemsettings startup isn't shown anymore (*KXMLGUI file found at deprecated location ("/usr/share/systemsettings/systemsettingsui.rc") -- please use ${KXMLGUI_INSTALL_DIR} to install this file instead.*)
> 
> 
> Diffs
> -----
> 
>   app/CMakeLists.txt c45f7e7a42b6147253232d2b6e5496346390664a 
> 
> Diff: https://git.reviewboard.kde.org/r/119281/diff/
> 
> 
> Testing
> -------
> 
> systemsettings works.
> No deprecation notice shown anymore.
> 
> 
> Thanks,
> 
> Elias Probst
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140714/39bde4f4/attachment.html>


More information about the Plasma-devel mailing list