Review Request 119276: Use 'KXMLGUI_INSTALL_DIR' instead of 'DATA_INSTALL_DIR'

Elias Probst mail at eliasprobst.eu
Mon Jul 14 17:22:22 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119276/
-----------------------------------------------------------

Review request for Plasma.


Repository: kinfocenter


Description
-------

The kxmlgui file for kinfocenter is installed into a deprecated location.
This patch fixes this and the deprecation notice on kinfocenter startup isn't shown anymore (*KXMLGUI file found at deprecated location ("/usr/share/kinfocenter/kinfocenterui.rc") -- please use ${KXMLGUI_INSTALL_DIR} to install this file instead.*)

Besides that, I cleaned up the XML formatting/indendation a bit using xmllint.


Diffs
-----

  CMakeLists.txt fa8b7ce250f14710c487ce26c07a0a2dd9d1f0b8 
  kinfocenterui.rc f9846368d733de973623ac64af3064c225d85458 

Diff: https://git.reviewboard.kde.org/r/119276/diff/


Testing
-------

kinfocenter works.
No deprecation notice shown anymore.


Thanks,

Elias Probst

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140714/290078fa/attachment.html>


More information about the Plasma-devel mailing list