Review Request 119270: Autotest for corona restore and behavior

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119270/#review62294
-----------------------------------------------------------



autotests/coronatest.cpp
<https://git.reviewboard.kde.org/r/119270/#comment43276>

    That's not you.



autotests/coronatest.cpp
<https://git.reviewboard.kde.org/r/119270/#comment43277>

    that's frickin' clever!
    
    (not really a review comment I just wanted to say I thought it was nicely done)



autotests/coronatest.cpp
<https://git.reviewboard.kde.org/r/119270/#comment43278>

    Why?
    
    I thought the overriding the plugin loader was so we don't need real plugins.



autotests/coronatest.cpp
<https://git.reviewboard.kde.org/r/119270/#comment43279>

    why is this commented out?



autotests/coronatest.cpp
<https://git.reviewboard.kde.org/r/119270/#comment43280>

    leaks.



autotests/coronatest.cpp
<https://git.reviewboard.kde.org/r/119270/#comment43281>

    This will wipe the tester's settings, no?



autotests/coronatest.cpp
<https://git.reviewboard.kde.org/r/119270/#comment43282>

    maybe it's worth checking the sub-containments and applets immutiablity is propogated.


- David Edmundson


On July 14, 2014, 12:30 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119270/
> -----------------------------------------------------------
> 
> (Updated July 14, 2014, 12:30 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This is a simple autotest for loading a simple corona, checking that the uiready signals are emitted, that adding and removing applets work, and the immutability settings do work.
> 
> The test is now passing and pretty basic, if someone can think about any new things to test, please add in the test ;)
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt 060132d 
>   autotests/coronatest.h PRE-CREATION 
>   autotests/coronatest.cpp PRE-CREATION 
>   autotests/coronatestresources.qrc PRE-CREATION 
>   autotests/plasma-test-appletsrc PRE-CREATION 
>   src/plasma/corona.cpp e18f081 
>   src/plasma/private/containment_p.cpp f8b4578 
> 
> Diff: https://git.reviewboard.kde.org/r/119270/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140714/402b0fa9/attachment-0001.html>