Review Request 119252: Use KXMLGUI_INSTALL_DIR instead of DATA_INSTALL_DIR for .rc files
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Jul 14 09:23:21 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119252/#review62271
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On July 12, 2014, 11:03 p.m., Elias Probst wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119252/
> -----------------------------------------------------------
>
> (Updated July 12, 2014, 11:03 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> kfontview shows these deprecation messages on startup:
> KXMLGUI file found at deprecated location ("/usr/share/kfontinst/kfontviewpart.rc") -- please use ${KXMLGUI_INSTALL_DIR} to install this file instead.
> KXMLGUI file found at deprecated location ("/usr/share/kfontview/kfontviewui.rc") -- please use ${KXMLGUI_INSTALL_DIR} to install this file instead.
>
> This patch fixes that and might also prevent a possible collision when co-installing Plasma Desktop 5 with KDE SC 4.
>
>
> Diffs
> -----
>
> kcms/kfontinst/apps/CMakeLists.txt f3c6a670dac04fe937cdfbbf152996aee605965c
> kcms/kfontinst/viewpart/CMakeLists.txt f79d7a6cd6706cb8d25155a35f35e4748247acfe
>
> Diff: https://git.reviewboard.kde.org/r/119252/diff/
>
>
> Testing
> -------
>
> No more deprecation notices on kfontview startup.
>
>
> Thanks,
>
> Elias Probst
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140714/8e4f8f0c/attachment-0001.html>
More information about the Plasma-devel
mailing list