Review Request 119232: Rewrite the Calendar component grid + small refactor

[David Edmundson]

> On July 12, 2014, 2:55 p.m., Eike Hein wrote:
> > To be honest I'm not happy with the visual results in either version, the bright puxels from overlaps are ugly. Why can't we use a single Canvas element to paint it all properly instead of using rects?
> 
> Martin Klapetek wrote:
>     I've moved the inner lines to be adjacent to the outer frame so now there are only overlaps in the inner crossings and honestly I can't really spot them.
>     
>     However, I'm not familiar with Canvas, could be very well tried out. Care to give it a try? ;)

I don't get why they're brighter anyway. borderOpacity is 1.0, so if they overlap that shouldn't have any impact?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119232/#review62191
-----------------------------------------------------------


On July 12, 2014, 11:52 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119232/
> -----------------------------------------------------------
> 
> (Updated July 12, 2014, 11:52 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Currently the grid itself is composed of 88 rectangles that draw all the lines in a way that two big rect draws the whole two topmost horizontal and leftmost vertical border lines and then each day rectangle is drawing small bottom and right rect.
> 
> This patch reduces it to 13 rects only where one rect draws the whole frame around the grid and then 1px wide/high rects draw the inner lines. Results in much cleaner & simple code.
> 
> Plus there's a small refactor on the id names so it makes more sense.
> 
> This does not require any additional changes in the applets.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/calendar/qml/MonthMenu.qml 5209816 
>   src/declarativeimports/calendar/qml/MonthView.qml ba3fe95 
>   src/declarativeimports/calendar/qml/CalendarToolbar.qml cd28702 
>   src/declarativeimports/calendar/qml/DayDelegate.qml 11f0afa 
>   src/declarativeimports/calendar/qml/DaysCalendar.qml ae9df01 
> 
> Diff: https://git.reviewboard.kde.org/r/119232/diff/
> 
> 
> Testing
> -------
> 
> All applets using the Calendar component looks exactly the same and work perfectly fine with no changes in the applets.
> 
> 
> File Attachments
> ----------------
> 
> digital-clock before/after
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/07/11/9a4f02eb-b06c-4d13-8ea5-94276659fba8__plasma_cal4.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140712/2e839174/attachment.html>