Review Request 119220: Figure out why my plasma wasn't notifying the startup

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119220/#review62154
-----------------------------------------------------------

Ship it!


So, it can go in for now,
I decided to stop talking and act, so there is the branch in plasma-framework (yes, i'm a naughty boy)
mart/coronaautotest
is a simple autotest on corona/containment/applets layout stuff (not graphic, purely model)
monday i'll merge and unbreak the part of the test that should test the code in this review

- Marco Martin


On July 11, 2014, 5:33 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119220/
> -----------------------------------------------------------
> 
> (Updated July 11, 2014, 5:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Make sure AppletPrivate::uiReady is set in applet_p.cpp when we report that the ui is ready.
> Make sure that if we loop through all the containments and they're all ready, we emit that it's done.
> 
> So far, Corona::startupCompleted was never emitted.
> 
> 
> Diffs
> -----
> 
>   src/plasma/corona.h baa9ee9 
>   src/plasma/corona.cpp e18f081 
>   src/plasma/private/applet_p.cpp 4fe27c9 
> 
> Diff: https://git.reviewboard.kde.org/r/119220/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> pf-startup.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/07/11/e5b15661-6507-441e-94cc-ed7828ab0ff9__pf-startup.patch
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140711/cb194fe8/attachment-0001.html>