Review Request 119229: Remove wrong changes to ToolboxButton

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119229/#review62127
-----------------------------------------------------------

Ship it!


eh, thinking about it, the actual bug there was that not everyhing scales at the same time because different things in unit fetch the pretended dpi in different ways.
but that's something to fix properly (leaving the toolbox alone)

- Marco Martin


On July 11, 2014, 10:37 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119229/
> -----------------------------------------------------------
> 
> (Updated July 11, 2014, 10:37 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 336209
>     https://bugs.kde.org/show_bug.cgi?id=336209
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Adapt iconsize to toolbox size introduces a blatant binding loop
> It was changed to be 0.8 of the frame, but the frame was based on the icon size.
> (line 78)
>     
> The binding loop was then "fixed" by wrapping in an item which is fixing something that was wrong in the first place rather than the root problem.
>     
> The iconSize comes from units.iconSize.Small in ToolBoxRoot in the first place, making the entire change pointless as it's 
> 
> If we do want to change the icon we just need to change that one line in ToolBoxRoot.
>     
> We certainly shouldn't be making changes that leave stray unused properties about. in ToolBoxRoot. 
>     
>     Revert "remove undetected binding loop"
>     
>     This reverts commit eddb56e5a7cac3cd631f1cb8e315af02f57779ee.
>     
>     Revert "use standard icons sizes for the toolbox icon"
>     
>     This reverts commit 216ee387648f7105561dabcf33d06ec880be65a3.
>     
>     Revert "Adapt icon size to toolbox size"
>     
> 
> 
> Diffs
> -----
> 
>   toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml 7923b711d28417dde2c48ef7acf42880c1ac9d3a 
> 
> Diff: https://git.reviewboard.kde.org/r/119229/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140711/36e99777/attachment.html>