Review Request 119227: Add FindOpenGLES

Eike Hein hein at kde.org
Fri Jul 11 09:29:24 UTC 2014



> On July 11, 2014, 9:20 a.m., Eike Hein wrote:
> > My bad, I didn't realize it was needed. I did actually ask a few people to review the CMake code this week, but they must have assumed it was there or dodn't realize either.
> > 
> > @Martin: You got to see the OpenGL code yesterday actually :).
> 
> Eike Hein wrote:
>     Note: This should probably go into the Plasma/5.0 branch and be merged up into master.
> 
> Heiko Becker wrote:
>     I don't have commit access, so I need somebody to push that for me. Thanks!

I'm on the road but can do it once I reach my desk. I'll also add Jonathan from the release team here in case he feels it's critical.


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119227/#review62116
-----------------------------------------------------------


On July 11, 2014, 8:12 a.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119227/
> -----------------------------------------------------------
> 
> (Updated July 11, 2014, 8:12 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Otherwise I get OpenGLES not found messages if Qt is compiled with support for OpenGLES.
> 
> 
> The actual cmake module is copied over from kwin.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt fd3680886b50527a0894b61d65d10eca665eec35 
>   cmake/modules/FindOpenGLES.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119227/diff/
> 
> 
> Testing
> -------
> 
> Configured, built and installed.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140711/47ad2ea8/attachment.html>


More information about the Plasma-devel mailing list