Review Request 119227: Add FindOpenGLES

Heiko Becker heirecka at exherbo.org
Fri Jul 11 08:57:37 UTC 2014



> On Juli 11, 2014, 8:48 vorm., Martin Gräßlin wrote:
> > is it needed at all? I'm surprised that something in plasma-desktop would use OpenGL at all, might be just a copy-paste error.

At least the cmake code claims folderplugin gets linked with OpenGLES (if it is found). The commit which introduced it is 85c20929b059ee2329124b1c13ed9f91b1cc6485.


- Heiko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119227/#review62114
-----------------------------------------------------------


On Juli 11, 2014, 8:12 vorm., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119227/
> -----------------------------------------------------------
> 
> (Updated Juli 11, 2014, 8:12 vorm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Otherwise I get OpenGLES not found messages if Qt is compiled with support for OpenGLES.
> 
> 
> The actual cmake module is copied over from kwin.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt fd3680886b50527a0894b61d65d10eca665eec35 
>   cmake/modules/FindOpenGLES.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119227/diff/
> 
> 
> Testing
> -------
> 
> Configured, built and installed.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140711/0339faed/attachment.html>


More information about the Plasma-devel mailing list