Review Request 119220: Figure out why my plasma wasn't notifying the startup

[Marco Martin]

> On July 10, 2014, 8:10 p.m., Marco Martin wrote:
> > src/plasma/private/applet_p.cpp, line 316
> > <https://git.reviewboard.kde.org/r/119220/diff/1/?file=289610#file289610line316>
> >
> >     when the code hits this path, uiready gets anyways set to true in line 333
> >     
> >     now, to be really precise is perhaps more correct setting uiready before emitting uiReadyChanged, but in this case the other uiready= true should be moved from line 333 to before line 326 as well to have the property set before signal in the other case as well
> 
> Aleix Pol Gonzalez wrote:
>     It's already done, in the line 325. Actually, from that else branch, the uiReady is not needed because we're treating an applet, no?

yeah, it's doing it on the applet and not on itself tough.
so in theory uiready on line 333 shouldn't be needed.
this may change the behavior, so has to be checked wether gives any unwanted sideeffects


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119220/#review62094
-----------------------------------------------------------


On July 10, 2014, 6:14 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119220/
> -----------------------------------------------------------
> 
> (Updated July 10, 2014, 6:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Make sure AppletPrivate::uiReady is set in applet_p.cpp when we report that the ui is ready.
> Make sure that if we loop through all the containments and they're all ready, we emit that it's done.
> 
> So far, Corona::startupCompleted was never emitted.
> 
> 
> Diffs
> -----
> 
>   src/plasma/corona.h baa9ee9 
>   src/plasma/corona.cpp e18f081 
>   src/plasma/private/applet_p.cpp 4fe27c9 
> 
> Diff: https://git.reviewboard.kde.org/r/119220/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140711/9a7a288b/attachment-0001.html>