Review Request 119216: Don't connect to signals until the class has been initialized

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119216/#review62087
-----------------------------------------------------------

Ship it!


good catch (and since p-f already tagged, should be good to go)

- Marco Martin


On July 10, 2014, 5:06 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119216/
> -----------------------------------------------------------
> 
> (Updated July 10, 2014, 5:06 p.m.)
> 
> 
> Review request for Plasma and Vishesh Handa.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> While profiling plasmashell memory usage with Vishesh we realized that most of the usage came from loading the Background image repeatedly.
> 
> We traced it back to this change, where we were connecting to wallpaperChanged before initializing it, so it would initialize it again, loading the wallpaper twice. It's not that we were leaking the object, AFAIK, but loading an image using QQuickImage already raises the memory quite a bit.
> 
> This change alone reduces by 15% the memory usage of my plasmashell (with 2 screens, that makes it a bit worse, because there's 2 DesktopViews then).
> 
> 
> Diffs
> -----
> 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 4764430 
> 
> Diff: https://git.reviewboard.kde.org/r/119216/diff/
> 
> 
> Testing
> -------
> 
> Ran the tests, although I don't think they do much. Also played around with it.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140710/d0a5d162/attachment-0001.html>