Review Request 119176: Update kickoff when user's name or face image changed

[Sebastian Kügler]

> On July 9, 2014, 11:47 a.m., Aleix Pol Gonzalez wrote:
> > I still don't love it, but seems to do what it has to do.
> > 
> > Maybe add a comment for the temporaryEmptyFace, in case we manage to get better api for this in the future.

I don't like it either, and we'll have to find a better way (which will likely involve API changes and merging similar code into a framework). Needs discussion, though.

There's a comment about the empty face var when it's set, so that's sufficiently clear, I think.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119176/#review61966
-----------------------------------------------------------


On July 8, 2014, 1:19 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119176/
> -----------------------------------------------------------
> 
> (Updated July 8, 2014, 1:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 336792
>     https://bugs.kde.org/show_bug.cgi?id=336792
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
>     Since KUser doesn't provide any change signalling, we're watching both,
>     /etc/passwd (if it exists) and the face icon path for changes. The
>     latter is a pretty static thing in KUser, so it's safe to assume it
>     doesn't change at runtime.
>     
>     This makes updating the user's full name and face image from
>     Personal Settings / Password & User Account update Kickoff's header work
>     at runtime
> 
> 
> Diffs
> -----
> 
>   applets/kickoff/core/kuserproxy.h ec77217 
>   applets/kickoff/core/kuserproxy.cpp 713a182 
>   applets/kickoff/package/contents/ui/Header.qml 75e2d97 
> 
> Diff: https://git.reviewboard.kde.org/r/119176/diff/
> 
> 
> Testing
> -------
> 
> Changed user information, watched Kickoff update automatically.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140709/36421da3/attachment.html>