Review Request 119191: Only consider a containment as finished if it actually passes a "true".

Marco Martin notmart at gmail.com
Wed Jul 9 10:42:06 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119191/#review61958
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On July 9, 2014, 10:11 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119191/
> -----------------------------------------------------------
> 
> (Updated July 9, 2014, 10:11 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> So far, we were only considering the fact that teh signal was being emitted, and that's doesn't seemcorrect.
> 
> 
> Diffs
> -----
> 
>   src/plasma/corona.cpp 20d61a0 
> 
> Diff: https://git.reviewboard.kde.org/r/119191/diff/
> 
> 
> Testing
> -------
> 
> I don't know how to test it.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140709/91853110/attachment.html>


More information about the Plasma-devel mailing list