Review Request 119180: Remove page when adding widgets to select what type of applet to install + fix install

Aleix Pol Gonzalez aleixpol at kde.org
Tue Jul 8 17:32:19 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119180/#review61919
-----------------------------------------------------------

Ship it!


Looks good to me.

- Aleix Pol Gonzalez


On July 8, 2014, 2:37 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119180/
> -----------------------------------------------------------
> 
> (Updated July 8, 2014, 2:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> 
>     Remove page when adding widgets to select what type of applet to install
>     
>     We only support one
> 
> --
> -
>     Correctly install applets
>     
>     Plasma/Plasmoid does not exist! This would just crash.
> 
> 
> Diffs
> -----
> 
>   shell/widgetexplorer/openwidgetassistant.cpp 1acacb8 
>   shell/widgetexplorer/openwidgetassistant_p.h edfb1c7 
> 
> Diff: https://git.reviewboard.kde.org/r/119180/diff/
> 
> 
> Testing
> -------
> 
> Created a zip file from plasma-framework/examples/applets/notes
> 
> installed it. It appeared!
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140708/f23f5fb2/attachment.html>


More information about the Plasma-devel mailing list