Review Request 119092: Add "sudo" to the make install command in the README file

Sebastian Kügler sebas at kde.org
Tue Jul 8 13:24:04 UTC 2014



> On July 3, 2014, 5:27 a.m., Martin Gräßlin wrote:
> > this is a very bad suggestion. Given the README it will install into /usr in case of distro users. Don't do that, this can break installs. Adjust the cmake command to install to a local prefix.
> 
> R.Harish  Navnit wrote:
>     Okay, but what should/could the local prefix be ?

Whereever the user (developer in this case) wants. Prefix is really a widely understood concept, no use in explaining it here. (If the person reading this file doesn't understand it, no real use in compiling PMC.)

I'd just drop this RR.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119092/#review61519
-----------------------------------------------------------


On July 2, 2014, 10:53 p.m., R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119092/
> -----------------------------------------------------------
> 
> (Updated July 2, 2014, 10:53 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Giving the command "make install" without sudo doesn't work. Has this gone un-noticed or is this how it is intended in the README ? 
> 
> 
> Diffs
> -----
> 
>   README 6f46cdf 
> 
> Diff: https://git.reviewboard.kde.org/r/119092/diff/
> 
> 
> Testing
> -------
> 
> Ran "sudo make install" and build succeeds. 
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140708/700082a0/attachment.html>


More information about the Plasma-devel mailing list