Review Request 119176: Update kickoff when user's name or face image changed

[Sebastian Kügler]

> On July 8, 2014, 1:02 p.m., Aleix Pol Gonzalez wrote:
> > applets/kickoff/core/kuserproxy.cpp, line 53
> > <https://git.reviewboard.kde.org/r/119176/diff/1/?file=289033#file289033line53>
> >
> >     Maybe we should open a wish in Qt? Or implement it in IconItem?
> >     
> >     We can't be always doing that.

We're using an Image here, that would need a change in Qt. It's actually the first time, I run into this usecase, I don't think at this point we'd gain much by adding it to  Qt.


> On July 8, 2014, 1:02 p.m., Aleix Pol Gonzalez wrote:
> > applets/kickoff/package/contents/ui/Header.qml, line 2
> > <https://git.reviewboard.kde.org/r/119176/diff/1/?file=289034#file289034line2>
> >
> >     Unicode change that broke encoding, apparently at least.

Here, it's now correct. I'll leave it in. I like seeing my name properly displayed.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119176/#review61889
-----------------------------------------------------------


On July 8, 2014, 12:49 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119176/
> -----------------------------------------------------------
> 
> (Updated July 8, 2014, 12:49 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 336792
>     https://bugs.kde.org/show_bug.cgi?id=336792
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
>     Since KUser doesn't provide any change signalling, we're watching both,
>     /etc/passwd (if it exists) and the face icon path for changes. The
>     latter is a pretty static thing in KUser, so it's safe to assume it
>     doesn't change at runtime.
>     
>     This makes updating the user's full name and face image from
>     Personal Settings / Password & User Account update Kickoff's header work
>     at runtime
> 
> 
> Diffs
> -----
> 
>   applets/kickoff/core/kuserproxy.h ec77217 
>   applets/kickoff/core/kuserproxy.cpp 713a182 
>   applets/kickoff/package/contents/ui/Header.qml 75e2d97 
> 
> Diff: https://git.reviewboard.kde.org/r/119176/diff/
> 
> 
> Testing
> -------
> 
> Changed user information, watched Kickoff update automatically.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140708/66fbe2ad/attachment.html>