Review Request 119173: attempt a different kickoff design
Sebastian Kügler
sebas at kde.org
Tue Jul 8 11:42:45 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119173/#review61881
-----------------------------------------------------------
Ship it!
Good to go in from my side. I never really liked not showing the application name, so I think this is a nice compromise. And it doesn't crash. ;)
applets/kickoff/package/contents/ui/KickoffItem.qml
<https://git.reviewboard.kde.org/r/119173/#comment43090>
We use 0.3 and 0.6 elsewhere, might make sense to do it here, too.
- Sebastian Kügler
On July 8, 2014, 11:38 a.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119173/
> -----------------------------------------------------------
>
> (Updated July 8, 2014, 11:38 a.m.)
>
>
> Review request for Plasma and Sebastian Kügler.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> this has two reasons: works around https://bugs.kde.org/show_bug.cgi?id=336493 by removing animations
> and makes it look more quiet, not having things moving around (it may be the "bad" type of animation"
>
> it makes the subtitles always appear, but very faint, and go opaque only under mouse
>
>
> Diffs
> -----
>
> applets/kickoff/package/contents/ui/KickoffItem.qml bff289f
>
> Diff: https://git.reviewboard.kde.org/r/119173/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> kickoff.png
> https://git.reviewboard.kde.org/media/uploaded/files/2014/07/08/1d4dfa82-7f49-408b-acde-bc1121a35d4b__kickoff.png
>
>
> Thanks,
>
> Marco Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140708/1c7a81c0/attachment.html>
More information about the Plasma-devel
mailing list