Review Request 119165: store the containment as a qpointer
Marco Martin
notmart at gmail.com
Tue Jul 8 08:36:10 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119165/
-----------------------------------------------------------
(Updated July 8, 2014, 8:36 a.m.)
Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez.
Repository: plasma-framework
Description
-------
This solves the crash
http://pastebin.com/tMYdgpUT
the problem is that sometimes when QCoreApplication::aboutToQuit the containment is already deleted (the order is not really deterministic), therefore appletScript::applet() will hit an assert.
using a qpointer should solve it, its data being already 0ed in the cases the containment is already deleted at :aboutToquit time.
Diffs (updated)
-----
src/scriptengines/qml/plasmoid/containmentinterface.h 3ecdddf
src/scriptengines/qml/plasmoid/containmentinterface.cpp f1762fe
Diff: https://git.reviewboard.kde.org/r/119165/diff/
Testing
-------
Thanks,
Marco Martin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140708/972f9554/attachment.html>
More information about the Plasma-devel
mailing list