Review Request 119165: store the containment as a qpointer

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119165/#review61861
-----------------------------------------------------------



src/scriptengines/qml/plasmoid/containmentinterface.h
<https://git.reviewboard.kde.org/r/119165/#comment43074>

    why can't this be const anymore?



src/scriptengines/qml/plasmoid/containmentinterface.cpp
<https://git.reviewboard.kde.org/r/119165/#comment43075>

    If the containment is removed before the containmentInterface (the cause of this crash) why do we need this slot at all?


- David Edmundson


On July 7, 2014, 8:10 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119165/
> -----------------------------------------------------------
> 
> (Updated July 7, 2014, 8:10 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This solves the crash
> http://pastebin.com/tMYdgpUT
> 
> the problem is that sometimes when QCoreApplication::aboutToQuit the containment is already deleted (the order is not really deterministic), therefore appletScript::applet() will hit an assert.
> using a qpointer should solve it, its data being already 0ed in the cases the containment is already deleted at :aboutToquit time.
> 
> 
> Diffs
> -----
> 
>   src/scriptengines/qml/plasmoid/containmentinterface.h 3ecdddf 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp f1762fe 
> 
> Diff: https://git.reviewboard.kde.org/r/119165/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140707/e78014fe/attachment-0001.html>