Review Request 119160: Make sure the backtrace dialog isn't closed when the bug reporting assistant is launched

Aleix Pol Gonzalez aleixpol at kde.org
Mon Jul 7 18:23:17 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119160/#review61845
-----------------------------------------------------------



drkonqi/drkonqidialog.cpp
<https://git.reviewboard.kde.org/r/119160/#comment43050>

    I don't think this works, the syntax in the slot is broken.


- Aleix Pol Gonzalez


On jul. 7, 2014, 4:57 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119160/
> -----------------------------------------------------------
> 
> (Updated jul. 7, 2014, 4:57 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Turns out that KGlobal kept a ref count of windows earlier, and only destroyed everything when the refcount went down to 0. Since drkonqi was ported away from that, we need to make sure that drkonqi isn't closed before the bug reporter assistant finishes
> 
> 
> Diffs
> -----
> 
>   drkonqi/drkonqidialog.cpp 7dc4021 
> 
> Diff: https://git.reviewboard.kde.org/r/119160/diff/
> 
> 
> Testing
> -------
> 
> Launched konsole
> killall -SEGV konsole
> Clicked on report bug
> bug reported on bugs.kde.org succesfully
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140707/58a0f6ce/attachment.html>


More information about the Plasma-devel mailing list