Review Request 119159: Add a internal copy of kxmlrpcclient to plasma-workspace

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119159/#review61833
-----------------------------------------------------------



drkonqi/CMakeLists.txt
<https://git.reviewboard.kde.org/r/119159/#comment43041>

    You only want to add all these in case you're building with bugzilla integration



drkonqi/config-drkonqi.h.cmake
<https://git.reviewboard.kde.org/r/119159/#comment43040>

    @KF5XmlRpcClient_FOUND@ << just set it to true? there's nothing to find anyway.
    
    Also it would be good to have TODO or something so that we can change it back when xmlrpcclient is actually released



drkonqi/internalkxmlrpcclient/.krazy
<https://git.reviewboard.kde.org/r/119159/#comment43039>

    scrap that file. Or rather skip everything



drkonqi/internalkxmlrpcclient/.reviewboardrc
<https://git.reviewboard.kde.org/r/119159/#comment43038>

    scrap that file


- Aleix Pol Gonzalez


On July 7, 2014, 4:57 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119159/
> -----------------------------------------------------------
> 
> (Updated July 7, 2014, 4:57 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Added a internal copy of kxmlrpcclient to plasma-workspace so that the bug reporting button can be used.
> 
> 
> Diffs
> -----
> 
>   drkonqi/internalkxmlrpcclient/src/query.cpp PRE-CREATION 
>   drkonqi/internalkxmlrpcclient/src/query.h PRE-CREATION 
>   drkonqi/CMakeLists.txt 8224900 
>   drkonqi/bugzillaintegration/bugzillalib.h 570169b 
>   drkonqi/config-drkonqi.h.cmake 35b8330 
>   drkonqi/internalkxmlrpcclient/.krazy PRE-CREATION 
>   drkonqi/internalkxmlrpcclient/.reviewboardrc PRE-CREATION 
>   drkonqi/internalkxmlrpcclient/CMakeLists.txt PRE-CREATION 
>   drkonqi/internalkxmlrpcclient/COPYING.BSD PRE-CREATION 
>   drkonqi/internalkxmlrpcclient/KF5XmlRpcClientPrivateConfig.cmake.in PRE-CREATION 
>   drkonqi/internalkxmlrpcclient/Mainpage.dox PRE-CREATION 
>   drkonqi/internalkxmlrpcclient/README PRE-CREATION 
>   drkonqi/internalkxmlrpcclient/autotests/CMakeLists.txt PRE-CREATION 
>   drkonqi/internalkxmlrpcclient/autotests/testclient.h PRE-CREATION 
>   drkonqi/internalkxmlrpcclient/autotests/testclient.cpp PRE-CREATION 
>   drkonqi/internalkxmlrpcclient/autotests/testquery.h PRE-CREATION 
>   drkonqi/internalkxmlrpcclient/autotests/testquery.cpp PRE-CREATION 
>   drkonqi/internalkxmlrpcclient/src/CMakeLists.txt PRE-CREATION 
>   drkonqi/internalkxmlrpcclient/src/Messages.sh PRE-CREATION 
>   drkonqi/internalkxmlrpcclient/src/client.h PRE-CREATION 
>   drkonqi/internalkxmlrpcclient/src/client.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119159/diff/
> 
> 
> Testing
> -------
> 
> Launched konsole
> killall -SEGV konsole
> Drkonqi comes up
> Report bug button is enabled
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140707/427c937c/attachment.html>