Review Request 119145: Use qtpaths instead of kf5-confg in startkde
David Faure
faure at kde.org
Sun Jul 6 14:32:40 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119145/#review61724
-----------------------------------------------------------
Ship it!
You can push it after the two fixes below.
startkde/startkde.cmake
<https://git.reviewboard.kde.org/r/119145/#comment42949>
~/.config, rather.
(technically XDG_CONFIG_HOME, but ok, no need to be exhaustive). In fact the "i.e." should be "e.g." or "for instance" / "for example".
startkde/startkde.cmake
<https://git.reviewboard.kde.org/r/119145/#comment42950>
s/Move to/Use/ - we don't have to move any files :-)
- David Faure
On July 6, 2014, 1:46 p.m., Luca Beltrame wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119145/
> -----------------------------------------------------------
>
> (Updated July 6, 2014, 1:46 p.m.)
>
>
> Review request for KDE Frameworks, Plasma and David Faure.
>
>
> Bugs: 333793
> https://bugs.kde.org/show_bug.cgi?id=333793
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Currently env and shutdown scripts in startkde are not run due to the way kf5-config is used. There is no more $KDEHOME, so proper paths aren't being found.
>
> This patch moves things to qtpaths, putting things under ConfigLocation + "plasma-workspace" + "env" (or "shutdown"). This is what the plasma-desktop KCM does, but according to the discussion in [1] it may change depending on the outcome.
>
> [1] http://lists.kde.org/?t=140464151200002&r=1&w=2
>
>
> Diffs
> -----
>
> startkde/startkde.cmake 24610f4
>
> Diff: https://git.reviewboard.kde.org/r/119145/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Luca Beltrame
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140706/7a4935b1/attachment.html>
More information about the Plasma-devel
mailing list