Review Request 119116: KRunner: Show a "Configure" button on the side

Marco Martin notmart at gmail.com
Fri Jul 4 16:49:39 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119116/#review61610
-----------------------------------------------------------

Ship it!


looks good to me

- Marco Martin


On July 4, 2014, 4:11 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119116/
> -----------------------------------------------------------
> 
> (Updated July 4, 2014, 4:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Just like what krunner4 had
> 
> 
> Diffs
> -----
> 
>   krunner/view.h 86788f8 
>   krunner/view.cpp 488b342 
>   lookandfeel/contents/runcommand/RunCommand.qml 870ba86 
> 
> Diff: https://git.reviewboard.kde.org/r/119116/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> krunner_withconfig.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/07/04/32a97211-153a-4f42-b5bf-9ed4560acb34__krunner_withconfig.png
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140704/7e8cf80a/attachment.html>


More information about the Plasma-devel mailing list