Review Request 119103: Startkde: Remove KLOCALE_LANGUAGES

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119103/
-----------------------------------------------------------

(Updated July 4, 2014, 10:01 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
-------

    Startkde: Remove KLOCALE_LANGUAGES

    KLOCALE_LANGUAGES was used by the kde4 ksplash in order to to know which
    language to show. This environment variable is no longer used by the qml
    based ksplash. It makes no sense to have it.

    Additionally, this means we can stop linking against kdelibs4support.
    This is important cause kdostartupconfig blocks the rest of the boot
    sequence. On my system it causes a good 0.3 - 0.4 seconds delay. By no
    longer linking to kdelibs4support it takes less than 0.1 seconds and no
    longer shows up in the bootchat logs.


Diffs
-----

  startkde/kstartupconfig/CMakeLists.txt 6920fe5 
  startkde/kstartupconfig/kdostartupconfig.cpp d545f4f 
  startkde/startkde.cmake 40e3377 

Diff: https://git.reviewboard.kde.org/r/119103/diff/


Testing
-------


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140704/900cde07/attachment.html>