Review Request 119103: Startkde: Remove KLOCALE_LANGUAGES

[Vishesh Handa]

> On July 3, 2014, 11:41 a.m., Aleix Pol Gonzalez wrote:
> > Don't we still need to pass the language somehow? or now it will be enough with $LANG?

KLocale languages had a list of languages. The first one being the main one, and others being fallbacks. We no longer seem to support this "multiple languages" option in QLocale.

I'm not familiar with KSplash internals and why we ever needed to pass the languages variable at all.


- Vishesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119103/#review61543
-----------------------------------------------------------


On July 3, 2014, 11:25 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119103/
> -----------------------------------------------------------
> 
> (Updated July 3, 2014, 11:25 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
>     Startkde: Remove KLOCALE_LANGUAGES
> 
>     KLOCALE_LANGUAGES was used by the kde4 ksplash in order to to know which
>     language to show. This environment variable is no longer used by the qml
>     based ksplash. It makes no sense to have it.
> 
>     Additionally, this means we can stop linking against kdelibs4support.
>     This is important cause kdostartupconfig blocks the rest of the boot
>     sequence. On my system it causes a good 0.3 - 0.4 seconds delay. By no
>     longer linking to kdelibs4support it takes less than 0.1 seconds and no
>     longer shows up in the bootchat logs.
> 
> 
> Diffs
> -----
> 
>   startkde/kstartupconfig/CMakeLists.txt 6920fe5 
>   startkde/kstartupconfig/kdostartupconfig.cpp d545f4f 
>   startkde/startkde.cmake 40e3377 
> 
> Diff: https://git.reviewboard.kde.org/r/119103/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140703/0c14763f/attachment.html>