Review Request 119092: Add "sudo" to the make install command in the README file
Martin Gräßlin
mgraesslin at kde.org
Thu Jul 3 05:27:36 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119092/#review61519
-----------------------------------------------------------
this is a very bad suggestion. Given the README it will install into /usr in case of distro users. Don't do that, this can break installs. Adjust the cmake command to install to a local prefix.
- Martin Gräßlin
On July 3, 2014, 12:53 a.m., R.Harish Navnit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119092/
> -----------------------------------------------------------
>
> (Updated July 3, 2014, 12:53 a.m.)
>
>
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
>
>
> Repository: plasma-mediacenter
>
>
> Description
> -------
>
> Giving the command "make install" without sudo doesn't work. Has this gone un-noticed or is this how it is intended in the README ?
>
>
> Diffs
> -----
>
> README 6f46cdf
>
> Diff: https://git.reviewboard.kde.org/r/119092/diff/
>
>
> Testing
> -------
>
> Ran "sudo make install" and build succeeds.
>
>
> Thanks,
>
> R.Harish Navnit
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140703/209a99c3/attachment.html>
More information about the Plasma-devel
mailing list